Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] import with dot fails #50

Closed
rwong2888 opened this issue Nov 28, 2023 · 2 comments
Closed

[BUG] import with dot fails #50

rwong2888 opened this issue Nov 28, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@rwong2888
Copy link

Describe what happened:

got an error like below

Failed to scan: error scanning file <file.go>: error decorating file <file.go>: unsupported dot-import found for github.com/foo

Describe what you expected:

expected orchestrion to handle inserts, etc, however it failed on imports with dots. i had to rename the dot to bypass it, and then revert the rename. it would be good if dot would not break orchestrion

Steps to reproduce the issue:

import . github.com/foo

@rwong2888 rwong2888 added the bug Something isn't working label Nov 28, 2023
@RomainMuller
Copy link
Contributor

We're working on a relatively drastic orchestrion refactor/reshape, and this would most certainly correctly handle this case (although I need to add a test case specifically for this scenario).

We are trying to get a first iteration of the "new orchestion" available in the near future...

@RomainMuller
Copy link
Contributor

We have now released [email protected] which ought to address this issue, and has a new mode of operation. I'll close this issue now, but I encourage you to try it & let us know if you encounter any issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants