[pkg/quantile] Increase ulpLimit to prevent flakes #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Doubles ulpLimit to prevent
TestSummary/InsertNfrom failing (see sample failure).Motivation
TestSummary/InsertNis flaky in Go 1.20, but not on Go 1.19. This happens because of golang/go@90a67d0: we are not explicitly seeding themath/randRNG, which means the sequence of random numbers is fixed in Go 1.19 and below, but non-deterministic after it. See also golang/go/issues/54880.The test has probably been broken for a while, we just didn't notice because of the fixed inputs. We may want to revisit why the test is broken if we want to have a lower
ulpLimit, but 256 still seems acceptable.