Add gateway usage #479
Open
Add gateway usage #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #479 +/- ##
==========================================
+ Coverage 81.24% 81.26% +0.02%
==========================================
Files 48 49 +1
Lines 3668 3689 +21
==========================================
+ Hits 2980 2998 +18
- Misses 606 608 +2
- Partials 82 83 +1 ☔ View full report in Codecov by Sentry. |
ogaca-dd
added
Skip Changelog
breaking-change
liustanley
approved these changes
Jan 27, 2025
| @@ -143,16 +143,24 @@ func unsanitizedHostnameFromAttributes(attrs pcommon.Map) (string, bool) { | |||
| return "", false | |||
| } | |||
|
|
|||
| // HostFromAttributesHandler calls OnHost when a hostname is extracted from attributes. | |||
| type HostFromAttributesHandler interface { | |||
There was a problem hiding this comment.
Is there a reason for defining and using a new interface here instead of only using GatewayUsage?
|
|
||
| import "sync" | ||
|
|
||
| type GatewayUsage struct { |
There was a problem hiding this comment.
Could you add a comment describing GatewayUsage here?
truthbk
approved these changes
Jan 27, 2025
| import "sync" | ||
|
|
||
| type GatewayUsage struct { | ||
| fistHostname string |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a way to know if OTEL is used in a gateway setup.
In order to do so, it checks if
datadog.host.namewas sent with two different values.See #479 for additional context.
Motivation