Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OTEL-1171: Extract trace/span ID from trace_id and span_id #206

Merged
merged 1 commit into from
Dec 4, 2023
Merged

OTEL-1171: Extract trace/span ID from trace_id and span_id #206

merged 1 commit into from
Dec 4, 2023

Conversation

mackjmr
Copy link
Member

@mackjmr mackjmr commented Dec 1, 2023

What does this PR do?

This PR extracts the trace and span ID from log attributes trace_id and span_id.

Motivation

Remove need to add trace operator:

    operators:
      - type: json_parser
      - type: trace_parser
        trace_id:
          parse_from: attributes.trace_id
        span_id:
          parse_from: attributes.span_id

@mackjmr
OTEL-1171: Extract trace/span ID from trace_id and span_id
ceaa08a 
This PR extracts the trace and span ID from log attributes `trace_id` and `span_id`.
@mackjmr mackjmr requested a review from dineshg13 December 1, 2023 09:18
@mackjmr mackjmr requested a review from a team as a code owner December 1, 2023 09:18
@mackjmr mackjmr merged commit ab5bcde into main Dec 4, 2023
7 of 12 checks passed
@mackjmr mackjmr deleted the mackjmr/trace-id-logs branch December 4, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dineshg13 dineshg13 dineshg13 approved these changes

Assignees
No one assigned
Labels
Skip Changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mackjmr @dineshg13