Quantile: Add support for 32-bit bins #195
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
GeorgeHahn
force-pushed
the
single-machine-performance/generic-bins
branch
from
a99cb94 to
f121af5
Compare
GeorgeHahn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This change makes sketches generic over bin size and introduces a set of interfaces for interacting with them.
The generic boundary is placed below the
Agentsketch, which is effectively a buffer. This keeps interface overhead low. Buffering is enabled forAgent.CountBuffor the same reason. This results in a performance improvement across the board but the main goal there was to avoid a regression from interface overhead.This change is sibling to: DataDog/datadog-agent#20770
Motivation
This nets us a very significant performance win in datadog-agent's distribution handling.