-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jamie/kafka calls #389
jamie/kafka calls #389
Conversation
} | ||
|
||
// Reassignments returns a Reassignments from a given topics TopicMetadata. | ||
func (tm TopicMetadata) Reassignments() Reassignments { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we have a Reassignment struct that contains the reassignment for only one topic? It's sort of weird for TopicMetadata to hold a kv struct where the only key is the current topic name because TopicMetadata is already bound to a topic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's because Reassignments
is a pre-existing type; this method is to translate the new type TopicMetadata
(which belongs to a single topic) to a Reassignments
. In the ListReassignments
call, we get a TopicMetadata
->Reassignments
for all topics, merge them into a single Reassignments
.
kafkazk library
ListReassignments
callGetTopicMetadata
call for fetching v3 topic metadatazookeeper.go
filegeneral changes
todo
GetTopicMetadata
ListReassignments