Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jamie/kafka calls #389

Merged
merged 14 commits into from
Jan 31, 2022
Merged

jamie/kafka calls #389

merged 14 commits into from
Jan 31, 2022

Conversation

jamiealquiza
Copy link
Collaborator

kafkazk library

  • Adds a KIP-455 compatible ListReassignments call
  • Adds the GetTopicMetadata call for fetching v3 topic metadata
  • Splits types and errors out of the zookeeper.go file

general changes

  • Kafka 2.8 in the Docker compose setup
  • Revised Kafka listeners configuration

todo

  • Test coverage for GetTopicMetadata
  • Test coverage for ListReassignments

@jamiealquiza jamiealquiza changed the title Jamie/kafka calls jamie/kafka calls Jan 26, 2022
@jamiealquiza jamiealquiza marked this pull request as draft January 26, 2022 22:33
@jamiealquiza jamiealquiza marked this pull request as ready for review January 28, 2022 21:52
}

// Reassignments returns a Reassignments from a given topics TopicMetadata.
func (tm TopicMetadata) Reassignments() Reassignments {
Copy link
Contributor

@dopuskh3 dopuskh3 Jan 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have a Reassignment struct that contains the reassignment for only one topic? It's sort of weird for TopicMetadata to hold a kv struct where the only key is the current topic name because TopicMetadata is already bound to a topic.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's because Reassignments is a pre-existing type; this method is to translate the new type TopicMetadata (which belongs to a single topic) to a Reassignments. In the ListReassignments call, we get a TopicMetadata->Reassignments for all topics, merge them into a single Reassignments.

@jamiealquiza jamiealquiza requested a review from dopuskh3 January 31, 2022 15:28
@jamiealquiza jamiealquiza merged commit 1877b35 into master Jan 31, 2022
@jamiealquiza jamiealquiza deleted the jamie/kafka-calls branch January 31, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants