Topicmappr refactor #387
Merged
Topicmappr refactor #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PartitionMap.Topics() is already sorted.
mborst
force-pushed
the
mborst/topicmappr-library
branch
from
262be9d to
9e7adb4
Compare
mborst
force-pushed
the
mborst/topicmappr-library
branch
from
9e7adb4 to
295fcd6
Compare
| @@ -45,7 +45,10 @@ func rebalance(cmd *cobra.Command, _ []string) { | |||
| bootstrap(cmd) | |||
|
|
|||
| // ZooKeeper init. | |||
| zk, err := initZooKeeper(cmd) | |||
| zkAddr := cmd.Parent().Flag("zk-addr").Value.String() | |||
There was a problem hiding this comment.
I see you're experiencing the joy of extracting cobra flag vals
| case resultsByRange[i].storageRange > resultsByRange[j].storageRange: | ||
| return false | ||
| } | ||
| // TODO intentionally not handling the one error that can be returned here |
There was a problem hiding this comment.
I saw that the range increase error is always returned from printBrokerAssignmentStats; is the goal to conditionally handle it here rather than in that function I assume?
|
All around massively great clean up. Nothing to note beyond the comments here in the review. Also did a bit of local testing and don't have any concern getting this merged in. |
jamiealquiza
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor is intended to pave the way for topicmappr as a service or as a library.
Refactoring of error handling and potentially of logging are still missing, but will likely be handled separately.