clear buffers before returning to pool in v2.X #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewang-canva
changed the title
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On version 2.13.0 of the client, we noticed truncation of tags when metrics are sent during restart of the datadog agent. This was narrowed down to the issue #198 which was resolved in #200. However, we are not in a position to upgrade the datadog agent to 4.2.0 at this time.
This solution backports clear buffers from #200 into v2.X branch. Ultimately, we would like to see a v2.13.1 release to resolve this.
cc @vickenty
Cheers,
Andrew