Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable aggregation by default #171

Merged
merged 2 commits into from
Dec 6, 2021
Merged

Re-enable aggregation by default #171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f3ffd3
Re-enable aggregation by default
vickenty Nov 25, 2021
1dc3b95
Disable aggregation for telemetry tests
vickenty Nov 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/timgroup/statsd/NonBlockingStatsDClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ String tag() {
public static final boolean DEFAULT_BLOCKING = false;
public static final boolean DEFAULT_ENABLE_TELEMETRY = true;

public static final boolean DEFAULT_ENABLE_AGGREGATION = false;
public static final boolean DEFAULT_ENABLE_AGGREGATION = true;

public static final String CLIENT_TAG = "client:java";
public static final String CLIENT_VERSION_TAG = "client_version:";
Expand Down
1 change: 1 addition & 0 deletions src/test/java/com/timgroup/statsd/TelemetryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ public StatsDNonBlockingTelemetry(final String prefix, final int queueSize, Stri
.processorWorkers(processorWorkers)
.senderWorkers(senderWorkers)
.blocking(blocking)
.enableAggregation(false)
.enableTelemetry(enableTelemetry)
.telemetryFlushInterval(telemetryFlushInterval)
.resolve());
Expand Down