Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump datadog-checks-base version requirement #9718

Merged
merged 1 commit into from
Jul 16, 2021
Merged

Bump datadog-checks-base version requirement #9718

merged 1 commit into from
Jul 16, 2021

Conversation

djova
Copy link
Contributor

@djova djova commented Jul 16, 2021

What does this PR do?

Fixes broken nightly builds that were using an older version causing error obfuscate_sql() takes 2 positional arguments but 3 were given.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@djova
bump datadog-checks-base version
4700868 
Fixes broken nightly builds that were using an older version causing error `obfuscate_sql() takes 2 positional arguments but 3 were given`.
@djova djova requested a review from a team as a code owner July 16, 2021 13:53
@coignetp coignetp changed the title bump datadog-checks-base version Bump datadog-checks-base version requirement Jul 16, 2021
@codecov
Copy link

codecov bot commented Jul 16, 2021

Codecov Report

Merging #9718 (4700868) into master (fc9e44f) will increase coverage by 0.00%.
The diff coverage is n/a.

Flag Coverage Δ
mysql 85.23% <ø> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@djova djova merged commit d23a53f into master Jul 16, 2021
@djova djova deleted the djova/mysql-bump-base branch July 16, 2021 15:54
FlorianVeaux pushed a commit that referenced this pull request Jul 20, 2021
@djova @FlorianVeaux
bump datadog-checks-base version (#9718)
4b36f40 
Fixes broken nightly builds that were using an older version causing error `obfuscate_sql() takes 2 positional arguments but 3 were given`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coignetp coignetp coignetp approved these changes

@ofek ofek ofek approved these changes

Assignees
No one assigned
Labels
integration/mysql
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djova @ofek @coignetp