Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change DBM statement config keys and metric terminology to query #9661

Merged
merged 2 commits into from
Jul 9, 2021
Merged

Change DBM statement config keys and metric terminology to query #9661

merged 2 commits into from
Jul 9, 2021

Conversation

djova
Copy link
Contributor

@djova djova commented Jul 8, 2021

What does this PR do?

Adjust terminology in config keys & related metrics to replace statement with query.

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

Base automatically changed from djova/dbm-mysql-decouple-query-metrics-interval to master July 9, 2021 13:16
@djova
adjust dbm config keys and metric terminology: statement->query
2d0e118 
Adjust terminology in config keys & related metrics to replace `statement` with `query`.
@djova djova force-pushed the djova/dbm-mysql-adjust-terminology branch from 9a7b516 to 2d0e118 Compare July 9, 2021 13:24
@djova djova marked this pull request as ready for review July 9, 2021 13:42
@djova djova requested review from a team as code owners July 9, 2021 13:42
@codecov
Copy link

codecov bot commented Jul 9, 2021 •
edited
Loading

Codecov Report

Merging #9661 (c0d3592) into master (ad84ae6) will increase coverage by 0.00%.
The diff coverage is 94.28%.

Flag Coverage Δ
mysql 85.38% <94.28%> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

justiniso
justiniso previously approved these changes Jul 9, 2021
View reviewed changes
ruthnaebeck
ruthnaebeck approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@ruthnaebeck ruthnaebeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for docs

@ofek ofek changed the title adjust dbm config keys and metric terminology: statement->query Change DBM statement config keys and metric terminology to query Jul 9, 2021
@djova djova merged commit 1287450 into master Jul 9, 2021
@djova djova deleted the djova/dbm-mysql-adjust-terminology branch July 9, 2021 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justiniso justiniso justiniso left review comments

@ruthnaebeck ruthnaebeck ruthnaebeck approved these changes

@ofek ofek ofek approved these changes

Assignees
No one assigned
Labels
documentation integration/mysql
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@djova @justiniso @ofek @ruthnaebeck