Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBM statement_samples enabled by default, rename DBM-enabled key #9619

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

djova
Copy link
Contributor

@djova djova commented Jun 29, 2021

What does this PR do?

  • statement_samples.enabled now defaults to true
  • deep_database_monitoring renamed to dbm (while still supporting the old key)

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@djova djova requested review from a team as code owners June 29, 2021 20:22
@djova djova requested a review from a team as a code owner June 29, 2021 20:24
@djova djova changed the title change DBM statement_samples default and rename DBM-enabled key DBM statement_samples enabled by default, rename DBM-enabled key Jun 29, 2021
@codecov
Copy link

codecov bot commented Jun 30, 2021

Codecov Report

Merging #9619 (80d3ad4) into master (7ea81df) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

❗ Current head 80d3ad4 differs from pull request most recent head 7104133. Consider uploading reports for the commit 7104133 to get more accurate results
| Flag | Coverage Δ | |
|---|---|---|
| clickhouse | 96.95% <ø> (+0.40%) | ⬆️ |
| datadog_checks_base | 88.55% <ø> (-0.66%) | ⬇️ |
| elastic | 88.54% <ø> (ø) | |
| mysql | 85.76% <100.00%> (+1.10%) | ⬆️ |
| oracle | 93.58% <ø> (+1.23%) | ⬆️ |

Flags with carried forward coverage won't be shown. Click here to find out more.

* `statement_samples.enabled` now defaults to `true`
* `deep_database_monitoring` renamed to `dbm` (while still supporting the old key)
@djova djova merged commit 105414b into master Jul 1, 2021
@djova djova deleted the djova/mysql-dbm-config-updates branch July 1, 2021 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants