Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix insufficient rate limiting of statement samples #9585

Merged
merged 2 commits into from
Jun 24, 2021
Merged

Fix insufficient rate limiting of statement samples #9585

merged 2 commits into from
Jun 24, 2021

Conversation

djova
Copy link
Contributor

@djova djova commented Jun 22, 2021 •
edited
Loading

What does this PR do?

Fixes the previously incorrect rate limiting behavior which would allow ingestion of extra statement samples beyond the maxsize limit. The same problem existed for the explained_statements rate limit.

Additional Notes

Depends on #9582

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@djova djova requested review from a team as code owners June 22, 2021 18:23
@codecov
Copy link

codecov bot commented Jun 22, 2021 •
edited
Loading

Codecov Report

Merging #9585 (9f6f92a) into master (24ab906) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Flag Coverage Δ
mysql 85.44% <100.00%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@djova djova force-pushed the djova/mysql-statement-samples-rate-limit-fix branch from cb8fdb9 to c3c8b6c Compare June 22, 2021 20:26
@alexandre-normand alexandre-normand mentioned this pull request Jun 22, 2021
Merged
4 tasks
@djova
Fix insufficient mysql rate limiting of statement samples
20e886f 
Fixes the previously incorrect rate limiting behavior which would allow ingestion of extra statement samples beyond the `maxsize` limit. The same problem existed for the `explained_statements` rate limit.

Depends on #9582
@djova djova force-pushed the djova/mysql-statement-samples-rate-limit-fix branch from a7fa918 to 20e886f Compare June 24, 2021 18:34
@djova djova changed the title Fix insufficient mysql rate limiting of statement samples Fix insufficient rate limiting of statement samples Jun 24, 2021
@djova djova merged commit 4c2e274 into master Jun 24, 2021
@djova djova deleted the djova/mysql-statement-samples-rate-limit-fix branch June 24, 2021 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofek ofek ofek approved these changes

@alexandre-normand alexandre-normand alexandre-normand left review comments

Assignees
No one assigned
Labels
integration/mysql
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djova @alexandre-normand @ofek