ceph agent 8 signature #9520
Merged
ceph agent 8 signature #9520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
coignetp
approved these changes
Jun 21, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Jun 21, 2021
* Do not use instance argument on check method b487a8b
alexandre-normand
pushed a commit
that referenced
this pull request
Jun 24, 2021
* Do not use instance argument on check method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to use agent 8 signature (do not use instance in check method) and throws agent exceptions instead of a generic one