Properly close internal reply queues #9488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Codecov Report
|
hithwen
reviewed
Jun 8, 2021
| # https://github.com/dsuch/pymqi/blob/084ab0b2638f9d27303a2844badc76635c4ad6de/code/pymqi/__init__.py#L2892-L2902 | ||
| # https://dsuch.github.io/pymqi/examples.html#how-to-specify-dynamic-reply-to-queues | ||
| if pcf is not None: | ||
| pcf.disconnect() |
There was a problem hiding this comment.
any chances this can throw an exception?
There was a problem hiding this comment.
It shouldn't as exceptions are handled inside this method
https://github.com/dsuch/pymqi/blob/35d0e45ea16c0b2077b20906856f587d6f8ffa6a/code/pymqi/__init__.py#L2900-L2910
ofek
approved these changes
Jun 9, 2021
mx-psi
pushed a commit
that referenced
this pull request
Jul 27, 2021
I did not cherry-pick release PRs (#9708, #9492, #9456) nor documentation-only PRs (#9418, #9616, #9642) from git history to keep the commit as small as possible. PR #9400 is also relevant but it was already on the git history of this branch (see `git log -- ibm_mq` to double check). Don't emit any warnings if NO_MSG_AVAILABLE is received (#9452) (cherry picked from commit 13c10d9) Properly close internal reply queues (#9488) * Properly close internal reply queues * Define pcf (cherry picked from commit 9d395c0) Add debug line when there are no messages available (#9702) * Add debug line when there are no messages available (cherry picked from commit 3055228) Do not submit critical service check when there are no messages (#9703) (cherry picked from commit f0568c1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Close internal reply queue when collecting queue stats.
We tried to fix this in #8349 , but customer didn't test the beta release. Here is the original explaination of the fix:
A customer reported that the Agent writes to a dead-letter queue (DLQ) associated to
PYMQPCF.*.PYMQPCF.*is the prefix of internal queues (known as "reply queues") used by pymqi when executing a command.pcf.disconnect(), the reply queue gets properly closed, so no messages will be marked as "undelivered" since the queue is disposed.Motivation
Support case
Additional Notes
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached