Add v3 API metrics #9468
Merged
Add v3 API metrics #9468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
hithwen
reviewed
Jun 15, 2021
hithwen
approved these changes
Jun 16, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Jun 16, 2021
* Enable envoy discovery service * Attempt to Move version to 1.18.2 * Bump version to 1.18.3 * Update server version info * remove pip3 and use pip * add pip to envoy image * fix envoy yaml for api v3 * Add api v3 env * Add missing metrics * Update e2e tests * Fix metadata columns * Remove assert all * Assert metric v3 at least 0 * Fix metadata * Fix bench * Rename cluster_name tag * Add v3 metrics description Co-authored-by: HantingZHANG <[email protected]> Co-authored-by: Luis Gonzalez <[email protected]> 8920f58
alexandre-normand
pushed a commit
that referenced
this pull request
Jun 24, 2021
* Enable envoy discovery service * Attempt to Move version to 1.18.2 * Bump version to 1.18.3 * Update server version info * remove pip3 and use pip * add pip to envoy image * fix envoy yaml for api v3 * Add api v3 env * Add missing metrics * Update e2e tests * Fix metadata columns * Remove assert all * Assert metric v3 at least 0 * Fix metadata * Fix bench * Rename cluster_name tag * Add v3 metrics description Co-authored-by: HantingZHANG <[email protected]> Co-authored-by: Luis Gonzalez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Envoy v3 API is available, and there are a few new metrics.
This PR adds a new envoy environment, with a v3 API available so we can test against it.
Motivation
Close #8877
Additional Notes
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached