Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename cluster_name tag to envoy_cluster #9430

Merged
merged 5 commits into from
Jun 14, 2021
Merged

Rename cluster_name tag to envoy_cluster #9430

merged 5 commits into from
Jun 14, 2021

Conversation

coignetp
Copy link
Contributor

What does this PR do?

Rename tags:

  • cluster_name -> envoy_cluster
  • virtual_cluster_name -> virtual_envoy_cluster

with a configuration option for backward compatibility.

Same name as in spark config

integrations-core/spark/datadog_checks/spark/data/conf.yaml.example

Line 138 in 51a570a

disable_legacy_cluster_tag: true

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@coignetp coignetp requested review from a team as code owners May 27, 2021 13:19
@codecov
Copy link

codecov bot commented May 27, 2021 •
edited
Loading

Codecov Report

Merging #9430 (b2554de) into master (e9d9395) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Flag Coverage Δ
envoy 93.77% <100.00%> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
envoy/datadog_checks/envoy/metrics.py 100.00% <ø> (ø)
envoy/datadog_checks/envoy/envoy.py 70.45% <100.00%> (+0.22%) ⬆️
envoy/datadog_checks/envoy/parser.py 91.76% <100.00%> (+0.85%) ⬆️
envoy/tests/test_parser.py 100.00% <100.00%> (ø)
envoy/tests/common.py 92.30% <0.00%> (+7.69%) ⬆️

ruthnaebeck
ruthnaebeck suggested changes May 27, 2021
View reviewed changes
Copy link
Contributor

@ruthnaebeck ruthnaebeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs review

envoy/assets/configuration/spec.yaml Outdated Show resolved Hide resolved
ruthnaebeck
ruthnaebeck previously approved these changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@ruthnaebeck ruthnaebeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for docs

ofek
ofek requested changes Jun 11, 2021
View reviewed changes
envoy/assets/configuration/spec.yaml Show resolved Hide resolved
envoy/datadog_checks/envoy/data/conf.yaml.example Outdated Show resolved Hide resolved
@coignetp coignetp merged commit 76a6d3a into master Jun 14, 2021
@coignetp coignetp deleted the paul/envoy-tag branch June 14, 2021 10:30
alexandre-normand pushed a commit that referenced this pull request Jun 24, 2021
@coignetp @ruthnaebeck
@ofek @alexandre-normand
Rename cluster_name tag to envoy_cluster (#9430)
98e3b25 
* Rename cluster_name tag to envoy_cluster

* Sync models

* Update envoy/assets/configuration/spec.yaml

Co-authored-by: ruthnaebeck <[email protected]>

* Sync config file

* Apply suggestions from code review

Co-authored-by: Ofek Lev <[email protected]>

Co-authored-by: ruthnaebeck <[email protected]>
Co-authored-by: Ofek Lev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofek ofek ofek approved these changes

@ruthnaebeck ruthnaebeck ruthnaebeck left review comments

Assignees
No one assigned
Labels
documentation integration/envoy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coignetp @ofek @ruthnaebeck