Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix init failure when auth_ticket is not provided #9390

Merged
merged 1 commit into from
May 20, 2021

Conversation

coignetp
Copy link
Contributor

What does this PR do?

auth_ticket is not required for all environment, and assigning an environment variable with None raises an exception.

Motivation

Support case

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@coignetp coignetp requested a review from a team as a code owner May 20, 2021 09:21
@ghost ghost added the integration/mapr label May 20, 2021
@codecov
Copy link

codecov bot commented May 20, 2021

Codecov Report

Merging #9390 (4181f47) into master (02c6201) will not change coverage.
The diff coverage is 100.00%.

Flag Coverage Δ
mapr 84.97% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mapr/datadog_checks/mapr/mapr.py 69.07% <100.00%> (ø)

@coignetp coignetp merged commit b238485 into master May 20, 2021
@coignetp coignetp deleted the paul/mapr-fix-init branch May 20, 2021 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants