Account for name change in replica metrics #9230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
hithwen
force-pushed
the
js/msql-replication-metrics
branch
from
2fa8c59 to
6d44663
Compare
hithwen
force-pushed
the
js/msql-replication-metrics
branch
from
4042230 to
fdcf3bb
Compare
Merged
hithwen
force-pushed
the
js/msql-replication-metrics
branch
from
08ed446 to
460498e
Compare
FlorianVeaux
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding support for v8 API in #8402 I missed this.
The test is not reliable because replication metrics are not always emitted, added a note about that.
Changes included:
Followup: #9245