Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix retry parsing when metric has multiple metric parts #9189

Merged
merged 5 commits into from
Apr 20, 2021
Merged

Fix retry parsing when metric has multiple metric parts #9189

merged 5 commits into from
Apr 20, 2021

Conversation

ChristineTChen
Copy link
Contributor

What does this PR do?

Metric containing multiple metric_parts for a metric that doesn't exist causes a loop. This PR tracks skip_parts.

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@ChristineTChen ChristineTChen requested a review from a team as a code owner April 19, 2021 21:37
@ghost ghost added the integration/envoy label Apr 19, 2021
@FlorianVeaux FlorianVeaux merged commit c670cfb into master Apr 20, 2021
@FlorianVeaux FlorianVeaux deleted the cc/test-complex-cluster-name branch April 20, 2021 07:39
FlorianVeaux pushed a commit that referenced this pull request Apr 20, 2021
@ChristineTChen @FlorianVeaux
Fix retry parsing when metric has multiple metric parts (#9189)
1284bc2 
* Fix loop when cluster name contains multiple metric parts

* Fix style

* remove debug logs

* Use wordy cluster name

* Remove cluster name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luisgonzalex luisgonzalex luisgonzalex approved these changes

@FlorianVeaux FlorianVeaux FlorianVeaux approved these changes

@ofek ofek ofek approved these changes

Assignees
No one assigned
Labels
integration/envoy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChristineTChen @ofek @FlorianVeaux @luisgonzalex