Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow prometheus metrics path to be configurable #9028

Merged
merged 3 commits into from
Mar 24, 2021
Merged

Allow prometheus metrics path to be configurable #9028

merged 3 commits into from
Mar 24, 2021

Conversation

ChristineTChen
Copy link
Contributor

What does this PR do?

Some amazon msk instances may not expose metrics at /metrics path. This PR makes the path configurable.

Motivation

User req

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@ChristineTChen ChristineTChen requested review from a team as code owners March 24, 2021 19:19
@ChristineTChen ChristineTChen merged commit 535532e into master Mar 24, 2021
@ChristineTChen ChristineTChen deleted the cc/msk-path branch March 24, 2021 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luisgonzalex luisgonzalex luisgonzalex approved these changes

@mgarabed mgarabed mgarabed approved these changes

Assignees
No one assigned
Labels
documentation integration/amazon_msk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristineTChen @mgarabed @luisgonzalex