Add runtime configuration validation #8883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofek
force-pushed
the
ofek/sync_config_models_amazon_msk
branch
from
4c40360 to
dd2dfc7
Compare
ghost
added
the
| @@ -39,3 +39,6 @@ files: | |||
| - template: instances/openmetrics_legacy | |||
| overrides: | |||
| prometheus_url.hidden: true | |||
| prometheus_url.required: false | |||
| metrics.required: false | |||
There was a problem hiding this comment.
Should these two defaults to false directly in the openmetrics_legacy.yaml template file?
ofek
force-pushed
the
ofek/sync_config_models_amazon_msk
branch
from
96ab290 to
3322714
Compare
ofek
force-pushed
the
ofek/sync_config_models_amazon_msk
branch
from
3322714 to
390a734
Compare
FlorianVeaux
approved these changes
Mar 31, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Mar 31, 2021
* Sync config models * update * Update spec.yaml 8b23ba9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds config models from #8675