Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing Envoy HTTP router filter vhost metrics #8586

Merged
merged 1 commit into from
May 5, 2021
Merged

Add missing Envoy HTTP router filter vhost metrics #8586

merged 1 commit into from
May 5, 2021

Conversation

csssuf
Copy link
Contributor

@csssuf csssuf commented Feb 10, 2021 •
edited
Loading

What does this PR do?

Add a handful of missing Envoy metrics from the HTTP router filter. (https://www.envoyproxy.io/docs/envoy/v1.17.0/configuration/http/http_filters/router_filter.html?highlight=vhost#virtual-clusters)

Motivation

Using those metrics.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@csssuf csssuf requested a review from a team as a code owner February 10, 2021 18:24
@csssuf
Copy link
Contributor Author

csssuf commented Feb 24, 2021

Hi, quick ping on this - anything else needed from me?

@csssuf
Copy link
Contributor Author

csssuf commented Mar 22, 2021

Can somebody please take a look at this?

@hithwen hithwen merged commit 10fe9fc into DataDog:master May 5, 2021
@csssuf csssuf deleted the envoy-vhost-metrics branch May 5, 2021 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hithwen hithwen hithwen approved these changes

Assignees
No one assigned
Labels
integration/envoy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csssuf @hithwen