Support Aerospike 5.3 #8430
Merged
Support Aerospike 5.3 #8430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
ChristineTChen
force-pushed
the
cc/aerospike-5.3
branch
from
c9ba485 to
3812cf4
Compare
hithwen
previously approved these changes
Feb 1, 2021
ofek
requested changes
Feb 1, 2021
| # Also submit old latency names like `aerospike.namespace.latency.read_over_64ms` | ||
| if bucket in [1, 8, 64]: | ||
| latency_name = metric_name + '_over_{}ms'.format(str(bucket)) | ||
| self.send(NAMESPACE_LATENCY_METRIC_TYPE, latency_name, latencies[i], tags) |
There was a problem hiding this comment.
the legacy metrics are also tagged by the bucket:<num>
Co-authored-by: Ofek Lev <[email protected]>
Co-authored-by: Ofek Lev <[email protected]>
Co-authored-by: Ofek Lev <[email protected]>
Co-authored-by: Ofek Lev <[email protected]>
ofek
approved these changes
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Parse versions and ensure skipping deprecated commands gracefully.
aerospike.namespace.latency.*_over*msmetrics are now tagged by histogram bucket with generic name likeaerospike.namespace.latency.read. Backwards compatibility is maintained for the old naming convention.Mark deprecated metrics in metadata.csv
Motivation
dcscommand removed in5.0: https://www.aerospike.com/docs/reference/info/?show-removed=1#dcslatencycommand removed in5.2: https://www.aerospike.com/docs/reference/info/?show-removed=1#latencythroughputcommand removed in5.1: https://www.aerospike.com/docs/reference/info/?show-removed=1#throughputAdditional Notes
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached