Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update check signature #8258

Merged
merged 1 commit into from
Dec 29, 2020
Merged

Update check signature #8258

merged 1 commit into from
Dec 29, 2020

Conversation

coignetp
Copy link
Contributor

What does this PR do?

Update check signature from check(self, instance) to check(self, _)
Now throw a ConfigurationError in the constructor if the required stats_url option is not in the configuration file, instead of a KeyError in the check method

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@coignetp coignetp requested a review from a team as a code owner December 24, 2020 11:49
@ghost ghost added the integration/envoy label Dec 24, 2020
@ofek ofek merged commit ff05e14 into master Dec 29, 2020
@ofek ofek deleted the paul/envoy-signature branch December 29, 2020 19:23
github-actions bot pushed a commit that referenced this pull request Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants