Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[orchestrator] change cardinality of deployment count #8222

Merged
merged 4 commits into from
Dec 18, 2020

Conversation

nammn
Copy link
Contributor

@nammn nammn commented Dec 18, 2020

What does this PR do?

changes the cardinality count of previous added deployment.count.
Now running deployment.count should return the expected number of deployments without the need to filter_by

Motivation

Before one had to filter_by condition:available, status:true to get the correct count. But users would not expect this when calling deployment.count

Additional Notes

Check looks like this

    {
      "metric": "kubernetes_state.deployment.count",
      "points": [
        [
          1608292794,
          1
        ]
      ],
      "tags": [
        "namespace:default"
      ],
      "host": "agent-dev-nam",
      "type": "gauge",
      "interval": 0,
      "source_type_name": "System"
    },

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@nammn nammn requested review from a team as code owners December 18, 2020 11:32
@nammn nammn requested a review from a team December 18, 2020 11:33
@nammn nammn changed the title [orchestrator] fix cardinality of deployment count [orchestrator] change cardinality of deployment count Dec 18, 2020
mfpierre
mfpierre previously approved these changes Dec 18, 2020
Copy link
Contributor

@mfpierre mfpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor nit

@ChristineTChen ChristineTChen merged commit 9334526 into master Dec 18, 2020
@ChristineTChen ChristineTChen deleted the nnguyen/depl.count.exclude branch December 18, 2020 19:34
ChristineTChen pushed a commit that referenced this pull request Dec 18, 2020
* [orchestrator] fix cardinality of deployment count

* fix telemetry size

* fix flake8

* Update kubernetes_state/datadog_checks/kubernetes_state/kubernetes_state.py

Co-authored-by: Pierre Margueritte <[email protected]>

Co-authored-by: Pierre Margueritte <[email protected]>
mfpierre added a commit that referenced this pull request Dec 21, 2020
@mfpierre mfpierre mentioned this pull request Dec 21, 2020
4 tasks
ChristineTChen pushed a commit that referenced this pull request Dec 21, 2020
* Revert "[orchestrator] change cardinality of deployment count (#8222)"

This reverts commit 9334526.

* use kube_deployment_status_observed_generation to properly count deployments
ChristineTChen pushed a commit that referenced this pull request Dec 21, 2020
* Revert "[orchestrator] change cardinality of deployment count (#8222)"

This reverts commit 9334526.

* use kube_deployment_status_observed_generation to properly count deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants