Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update aerospike dependency #8044

Merged
merged 1 commit into from
Nov 17, 2020
Merged

Update aerospike dependency #8044

merged 1 commit into from
Nov 17, 2020

Conversation

gsalami00
Copy link
Contributor

What does this PR do?

Update aerospike dependency.

Motivation

Officially supporting Python 3.8:
https://github.com/aerospike/aerospike-client-python/releases/tag/4.0.0

aerospike/aerospike-client-python#214 (comment)
aerospike/aerospike-client-python#227 (comment)

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@gsalami00 gsalami00 requested review from a team as code owners November 17, 2020 17:42
@codecov
Copy link

codecov bot commented Nov 17, 2020

Codecov Report

Merging #8044 (8007c1f) into master (8eb2fa2) will decrease coverage by 3.11%.
The diff coverage is n/a.

Impacted Files Coverage Δ
nginx/tests/test_unit.py
hdfs_namenode/tests/test_hdfs_namenode.py
couch/tests/test_couchv2.py
datadog_checks_dev/datadog_checks/dev/spec.py
cockroachdb/datadog_checks/cockroachdb/__init__.py
istio/datadog_checks/istio/__init__.py
...se/datadog_checks/base/utils/metadata/constants.py
...ase/datadog_checks/base/utils/metadata/__init__.py
openstack_controller/tests/conftest.py
amazon_msk/tests/common.py
... and 907 more

ofek
ofek approved these changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@ofek ofek merged commit 9acb64e into master Nov 17, 2020
@ofek ofek deleted the gsalami00/update_aerospike_dependency branch November 17, 2020 18:16
@ofek ofek mentioned this pull request Jun 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofek ofek ofek approved these changes

Assignees
No one assigned
Labels
dependencies dev/testing integration/aerospike integration/datadog_checks_base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gsalami00 @ofek