Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use database config template in existing specs #7548

Merged
merged 5 commits into from
Sep 11, 2020
Merged

Use database config template in existing specs #7548

merged 5 commits into from
Sep 11, 2020

Conversation

ChristineTChen
Copy link
Contributor

What does this PR do?

Apply db template to integrations with the spec.yaml using the custom query options

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@ChristineTChen ChristineTChen requested review from a team as code owners September 8, 2020 22:34
@codecov
Copy link

codecov bot commented Sep 8, 2020 •
edited
Loading

Codecov Report

Merging #7548 into master will decrease coverage by 6.85%.
The diff coverage is n/a.

Impacted Files Coverage Δ
cilium/datadog_checks/cilium/__init__.py
linux_proc_extras/tests/test_linux_proc_extras.py
aspdotnet/tests/test_aspdotnet.py
apache/datadog_checks/apache/apache.py
go_expvar/datadog_checks/go_expvar/__about__.py
lighttpd/datadog_checks/lighttpd/__about__.py
...oller/datadog_checks/openstack_controller/retry.py
ceph/tests/conftest.py
...s_wildfly/datadog_checks/jboss_wildfly/__init__.py
mesos_slave/tests/test_integration.py
... and 715 more

@hithwen
Copy link
Contributor

hithwen commented Sep 9, 2020

And postgres?

kayayarai
kayayarai requested changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@kayayarai kayayarai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few docs clarifications

mysql/datadog_checks/mysql/data/conf.yaml.example Outdated Show resolved Hide resolved
mysql/datadog_checks/mysql/data/conf.yaml.example Outdated Show resolved Hide resolved
mysql/datadog_checks/mysql/data/conf.yaml.example Outdated Show resolved Hide resolved
@ChristineTChen ChristineTChen merged commit 7dfb7ab into master Sep 11, 2020
@ChristineTChen ChristineTChen deleted the cc/db-conf branch September 11, 2020 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgarabed mgarabed mgarabed approved these changes

@kayayarai kayayarai Awaiting requested review from kayayarai

Assignees
No one assigned
Labels
dev/tooling documentation integration/clickhouse integration/datadog_checks_dev integration/mysql integration/vertica
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ChristineTChen @hithwen @mgarabed @kayayarai @AlexandreYang