Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config specs #7292

Merged
merged 5 commits into from
Aug 5, 2020
Merged

Add config specs #7292

merged 5 commits into from
Aug 5, 2020

Conversation

coignetp
Copy link
Contributor

@coignetp coignetp commented Aug 5, 2020

What does this PR do?

Add config spec to mesos_slave integration

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@coignetp coignetp requested review from a team as code owners August 5, 2020 09:46
@codecov
Copy link

codecov bot commented Aug 5, 2020 •
edited
Loading

Codecov Report

Merging #7292 into master will increase coverage by 5.09%.
The diff coverage is n/a.

Impacted Files Coverage Δ
elastic/datadog_checks/elastic/__about__.py
ceph/tests/test_unit.py
...ver/datadog_checks/kube_metrics_server/__init__.py
couch/tests/common.py
mapr/tests/conftest.py
kafka/tests/conftest.py
.../datadog_checks/openstack_controller/exceptions.py
...ursor/datadog_checks/powerdns_recursor/__init__.py
kong/tests/test_integration_e2e.py
.../datadog_checks/exchange_server/exchange_server.py
... and 776 more

ChristineTChen
ChristineTChen requested changes Aug 5, 2020
View reviewed changes
Copy link
Contributor

@ChristineTChen ChristineTChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM left small nit with template priority

mesos_slave/assets/configuration/spec.yaml Outdated Show resolved Hide resolved
mesos_slave/assets/configuration/spec.yaml Outdated Show resolved Hide resolved
sarah-witt
sarah-witt previously approved these changes Aug 5, 2020
View reviewed changes
Copy link
Contributor

@sarah-witt sarah-witt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@coignetp coignetp merged commit d8c2832 into master Aug 5, 2020
@coignetp coignetp deleted the paul/mesos-s-spec branch August 5, 2020 14:47
github-actions bot pushed a commit that referenced this pull request Aug 5, 2020
@coignetp @ChristineTChen
Add config specs (#7292)
0f88fa7 
* Add config specs

* Apply suggestions from code review

Co-authored-by: Christine Chen <[email protected]>

* Sync configuration

* Update mesos_slave/assets/configuration/spec.yaml

Co-authored-by: Sarah Witt <[email protected]>

* Sync configuration

Co-authored-by: Christine Chen <[email protected]>
Co-authored-by: Sarah Witt <[email protected]> d8c2832
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristineTChen ChristineTChen ChristineTChen requested changes

@sarah-witt sarah-witt sarah-witt approved these changes

Assignees
No one assigned
Labels
documentation integration/mesos_slave
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coignetp @ChristineTChen @sarah-witt