Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract version utils #7198

Merged
merged 2 commits into from
Jul 24, 2020
Merged

Extract version utils #7198

merged 2 commits into from
Jul 24, 2020

Conversation

hithwen
Copy link
Contributor

@hithwen hithwen commented Jul 23, 2020 •
edited
Loading

Split of #7169

  • Added metadata entrypoint annotation so metadata submission can be skipped

@hithwen hithwen requested a review from a team as a code owner July 23, 2020 14:04
@hithwen hithwen force-pushed the julia/mysql-refactor-version-utils branch from f727e3d to 1f140b6 Compare July 23, 2020 14:06
@hithwen hithwen force-pushed the julia/mysql-refactor-version-utils branch from 1f140b6 to 7cb1a58 Compare July 23, 2020 14:55
@codecov
Copy link

codecov bot commented Jul 23, 2020 •
edited
Loading

Codecov Report

Merging #7198 into master will decrease coverage by 11.58%.
The diff coverage is 90.90%.

Impacted Files Coverage Δ
mysql/datadog_checks/mysql/mysql.py 71.33% <90.90%> (ø)
mysql/datadog_checks/mysql/version_utils.py 90.90% <90.90%> (ø)
openstack_controller/tests/conftest.py
istio/datadog_checks/istio/istio.py
tokumx/datadog_checks/tokumx/tokumx.py
cacti/datadog_checks/cacti/cacti.py
elastic/datadog_checks/elastic/elastic.py
crio/datadog_checks/crio/__init__.py
http_check/datadog_checks/http_check/__init__.py
ceph/datadog_checks/ceph/__init__.py
... and 758 more

@hithwen hithwen merged commit ba75932 into master Jul 24, 2020
@hithwen hithwen deleted the julia/mysql-refactor-version-utils branch July 24, 2020 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristineTChen ChristineTChen ChristineTChen approved these changes

Assignees
No one assigned
Labels
integration/mysql
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hithwen @ChristineTChen