Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert new jvm metrics #6996

Merged
merged 6 commits into from
Jun 26, 2020
Merged

Assert new jvm metrics #6996

merged 6 commits into from
Jun 26, 2020

Conversation

AlexandreYang
Copy link
Member

@AlexandreYang AlexandreYang commented Jun 26, 2020 •
edited
Loading

@AlexandreYang AlexandreYang requested a review from a team as a code owner June 26, 2020 12:50
@AlexandreYang AlexandreYang mentioned this pull request Jun 26, 2020
Closed
@codecov
Copy link

codecov bot commented Jun 26, 2020 •
edited
Loading

Codecov Report

Merging #6996 into master will decrease coverage by 6.33%.
The diff coverage is 72.22%.

Impacted Files Coverage Δ
cassandra/tests/test_check.py 44.44% <0.00%> (ø)
datadog_checks_dev/datadog_checks/dev/jmx.py 0.00% <0.00%> (ø)
solr/tests/common.py 85.71% <ø> (-0.96%) ⬇️
solr/tests/test_check.py 53.84% <50.00%> (+3.84%) ⬆️
tomcat/tests/test_check.py 53.84% <50.00%> (ø)
cassandra/tests/common.py 100.00% <100.00%> (ø)
hazelcast/tests/metrics.py 100.00% <100.00%> (ø)
ignite/tests/common.py 100.00% <100.00%> (ø)
jboss_wildfly/tests/test_check.py 36.36% <100.00%> (+6.36%) ⬆️
kafka/tests/common.py 100.00% <100.00%> (ø)
... and 683 more

@AlexandreYang AlexandreYang changed the title Add new jmx metric Assert new metric added to jmxfetch Jun 26, 2020
@AlexandreYang AlexandreYang changed the title Assert new metric added to jmxfetch Assert new jvm metric added to jmxfetch Jun 26, 2020
@AlexandreYang AlexandreYang changed the title Assert new jvm metric added to jmxfetch Assert new jvm metrics Jun 26, 2020
@AlexandreYang AlexandreYang merged commit 02e077a into master Jun 26, 2020
@AlexandreYang AlexandreYang deleted the alex/jvm_new_metric branch June 26, 2020 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah-witt sarah-witt sarah-witt approved these changes

@hithwen hithwen hithwen approved these changes

Assignees
No one assigned
Labels
integration/cassandra integration/datadog_checks_dev integration/hazelcast integration/ignite integration/jboss_wildfly integration/kafka integration/solr integration/tomcat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexandreYang @hithwen @sarah-witt @FlorianVeaux