-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note about warning concurrency #6967
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dev/tooling
integration/activemq_xml
integration/airflow
integration/ambari
integration/apache
integration/cisco_aci
integration/cloud_foundry_api
integration/consul
integration/datadog_checks_dev
integration/druid
integration/elastic
integration/fluentd
integration/gitlab
integration/hdfs_datanode
integration/hdfs_namenode
integration/http_check
integration/istio
integration/kong
integration/kube_apiserver_metrics
integration/nginx
integration/nginx_ingress_controller
integration/openmetrics
integration/spark
integration/twistlock
integration/vault
labels
Jun 24, 2020
Codecov Report
|
github-actions
bot
added
integration/ecs_fargate
integration/envoy
integration/etcd
integration/gitlab_runner
integration/go_expvar
integration/haproxy
integration/harbor
integration/ibm_was
integration/kyototycoon
integration/lighttpd
integration/mapreduce
integration/marathon
integration/mesos_master
integration/mesos_slave
integration/openstack_controller
integration/php_fpm
integration/powerdns_recursor
integration/rabbitmq
integration/scylla
integration/squid
integration/teamcity
integration/vsphere
integration/yarn
labels
Jun 26, 2020
AlexandreYang
approved these changes
Jun 26, 2020
ChristineTChen
approved these changes
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dev/tooling
integration/activemq_xml
integration/airflow
integration/ambari
integration/apache
integration/cisco_aci
integration/cloud_foundry_api
integration/consul
integration/couch
integration/couchbase
integration/datadog_checks_dev
integration/druid
integration/ecs_fargate
integration/elastic
integration/envoy
integration/etcd
integration/fluentd
integration/gitlab_runner
integration/gitlab
integration/go_expvar
integration/haproxy
integration/harbor
integration/hdfs_datanode
integration/hdfs_namenode
integration/http_check
integration/ibm_was
integration/istio
integration/kong
integration/kube_apiserver_metrics
integration/kyototycoon
integration/lighttpd
integration/mapreduce
integration/marathon
integration/mesos_master
integration/mesos_slave
integration/nginx_ingress_controller
integration/nginx
integration/openmetrics
integration/openstack_controller
integration/php_fpm
integration/powerdns_recursor
integration/rabbitmq
integration/scylla
integration/spark
integration/squid
integration/teamcity
integration/twistlock
integration/vault
integration/vsphere
integration/yarn
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a note to
tls_ignore_warning
configuration for the user to expect spurious warnings even when this is set to true.Motivation
Support case. Warnings are handled in a non thread-safe way (#5080), and while we decide the best approach here, we should make clear this race condition can happen.
Additional Notes
Modified the specs templates and the
http_check
. Once the note wording is approved I will add it to the other integrations.Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached