Add config spec #6908
Add config spec #6908
Conversation
Codecov Report
|
| # extra_performance_metrics: true | ||
|
|
||
| ## Log Section (Available for Agent >=6.0) | ||
| options: |
There was a problem hiding this comment.
(nit) Shall we keep that commented by default ? I guess doesn't change much to have an empty dict either.
There was a problem hiding this comment.
Yes I agree, but ddev doesn't seem to support it for now. I agree an empty options dict by default shouldn't be a problem since we do
options = instance.get('options', {}) or {} # options could be None if empty in the YAMLI can look at how to add commented-out-by-default sections to ddev, but looks like it's not a blocker to get this PR merged.
There was a problem hiding this comment.
Yes, not a blocker for this PR.
There was a problem hiding this comment.
@hithwen @AlexandreYang Thanks, I think I addressed all your comments.
florimondmanca
force-pushed
the
mysql-spec
branch
from
4b9d2ae to
c921e7b
Compare
| # # Columns without a name are ignored. Add additional columns to skip: | ||
| # # - {} |
There was a problem hiding this comment.
Not sure I understood this comment: is it that eg if the query returns 3 columns, we can do - {} on the first one and define the 2 others to only submit metrics for the last 2 columns? Not sure this is correct, since if the user wants to "skip columns" then they can just omit them in the SELECT clause 🤔 So I removed it for now.
There was a problem hiding this comment.
@ofek added this feature recently so he must remember what he meant
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Can you bump checks base on the setup to 11.0.0? (to include service features) |
What does this PR do?
Add config spec for MySQL
Motivation
Config specs everywhere! Also I might need to add a
charsetoption for a support case, so having the config spec done beforehand would be nice.Additional Notes
Not super happy with optional sections such as
ssl,custom_queriesorqueriesshowing up as un-commented in the generatedconf.yaml.example- but we can look at tweaking ddev later.Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached