Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom queries #6776

Merged
merged 3 commits into from
Jun 3, 2020
Merged

Add custom queries #6776

merged 3 commits into from
Jun 3, 2020

Conversation

ofek
Copy link
Contributor

@ofek ofek commented May 29, 2020

Motivation

Customer requests

@ofek ofek requested review from a team as code owners May 29, 2020 17:45
@codecov
Copy link

codecov bot commented May 29, 2020 •
edited
Loading

Codecov Report

Merging #6776 into master will decrease coverage by 11.40%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
mysql/datadog_checks/mysql/mysql.py 72.07% <100.00%> (ø)
mysql/tests/conftest.py 92.55% <100.00%> (ø)
mysql/tests/test_mysql.py 88.88% <100.00%> (ø)
iis/datadog_checks/iis/iis.py
hazelcast/tests/conftest.py
...ase/datadog_checks/base/utils/metadata/__init__.py
...s_base/datadog_checks/base/utils/metadata/utils.py
kubelet/datadog_checks/kubelet/__init__.py
..._namenode/datadog_checks/hdfs_namenode/__init__.py
...atadog_checks/active_directory/active_directory.py
... and 839 more

ruthnaebeck
ruthnaebeck suggested changes Jun 1, 2020
View reviewed changes
Copy link
Contributor

@ruthnaebeck ruthnaebeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs review

mysql/datadog_checks/mysql/data/conf.yaml.example Outdated Show resolved Hide resolved
mysql/datadog_checks/mysql/data/conf.yaml.example Outdated Show resolved Hide resolved
mysql/datadog_checks/mysql/data/conf.yaml.example Outdated Show resolved Hide resolved
mysql/datadog_checks/mysql/data/conf.yaml.example Outdated Show resolved Hide resolved
@ofek @ruthnaebeck @hithwen
Apply suggestions from code review
e857756 
Co-authored-by: ruthnaebeck <[email protected]>
Co-authored-by: Julia <[email protected]>
ruthnaebeck
ruthnaebeck approved these changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@ruthnaebeck ruthnaebeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for docs

@hithwen
Copy link
Contributor

hithwen commented Jun 3, 2020

Release after merge

@ofek ofek merged commit 50f3bc2 into master Jun 3, 2020
@ofek ofek deleted the ofek/m branch June 3, 2020 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruthnaebeck ruthnaebeck ruthnaebeck approved these changes

@hithwen hithwen hithwen approved these changes

Assignees
No one assigned
Labels
integration/mysql
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ofek @hithwen @ruthnaebeck