Add FiraCode font #6738
Merged
Add FiraCode font #6738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofek
requested changes
May 26, 2020
docs/developer/assets/css/custom.css
Outdated
| @@ -95,4 +95,11 @@ div.doc-contents:not(.first) { | |||
| 100% { | |||
| background-position: 6rem 0; } } | |||
|
|
|||
|
|
|||
| /* Fira code */ | |||
There was a problem hiding this comment.
Looks like we're in a TODO block, let's move it out
There was a problem hiding this comment.
Good catch, updated!
ofek
approved these changes
May 26, 2020
github-actions bot
pushed a commit
that referenced
this pull request
May 27, 2020
* Add Fira font * Move out of TODO * Add link in comment e1d9865
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds FiraCode font to code blocks in docs site.
Motivation
Makes symbols in code blocks more readable
Additional Notes
Example
before:
after:
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached