Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix debug log line for job metrics #6700

Merged
merged 1 commit into from
Jun 22, 2020
Merged

Conversation

khewonc
Copy link
Contributor

@khewonc khewonc commented May 20, 2020

What does this PR do?

Fix an issue where job metrics are missing when the agent uses DEBUG level logging

Motivation

Parsing the job label for job metrics when the agent is set to DEBUG logging results in the following type error:

2020-05-20 19:09:44 UTC | CORE | WARN | (pkg/collector/python/datadog_agent.go:118 in LogMessage) | kubernetes_state:5594cf03e448ecbf | (mixins.py:638) | Error handling metric: kube_job_status_failed - error: not all arguments converted during string formatting

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

Copy link
Contributor

@xornivore xornivore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@stale
Copy link

stale bot commented Jun 20, 2020

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Note that this will not be automatically closed, but the notification will remind us to investigate why there's been inactivity.

@stale stale bot added the stale label Jun 20, 2020
@ChristineTChen ChristineTChen merged commit 436eefe into master Jun 22, 2020
@ChristineTChen ChristineTChen deleted the caroline/job_debug_log branch June 22, 2020 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants