Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safer metadata error handling #6685

Merged
merged 1 commit into from
May 19, 2020
Merged

Safer metadata error handling #6685

merged 1 commit into from
May 19, 2020

Conversation

AlexandreYang
Copy link
Member

@AlexandreYang AlexandreYang commented May 19, 2020 •
edited
Loading

What does this PR do?

Safer metadata error handling

Motivation

  1. Collection might fail the check if the version payload data is invalid. e.g. missing version in data or index error at split('/')[1].

  2. Warning seems more appropriate since we don't expect failure.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@AlexandreYang AlexandreYang requested a review from a team as a code owner May 19, 2020 11:50
@AlexandreYang AlexandreYang changed the title Better metadata error handling Safer metadata error handling May 19, 2020
@AlexandreYang AlexandreYang merged commit a1c9331 into master May 19, 2020
@AlexandreYang AlexandreYang deleted the alex/envoy_metadata_error_handling branch May 19, 2020 14:36
ChristineTChen pushed a commit that referenced this pull request May 19, 2020
@AlexandreYang @ChristineTChen
Better metadata error handling (#6685)
31a8248
@sarah-witt sarah-witt mentioned this pull request May 20, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coignetp coignetp coignetp approved these changes

Assignees
No one assigned
Labels
integration/envoy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexandreYang @coignetp