[kubernetes] add option for node labels --> host tags #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hkaj, thanks for your PR! By analyzing the history of the files in this pull request, we identified @xvello, @gmmeyer and @olivielpeau to be potential reviewers. |
xvello
previously approved these changes
Jul 21, 2017
kubernetes/conf.yaml.example
Outdated
| @@ -97,6 +97,13 @@ instances: | |||
| # | |||
| # namespace_name_regexp: | |||
|
|
|||
| # Node labels that should be collected and their name in host tags. Off by default, but some of them are redundant | |||
There was a problem hiding this comment.
Do you mean "Off by default, as the common ones are redundant with ..." ?
hkaj
force-pushed
the
haissam/k8s-node-labels
branch
from
2e04779 to
9f1f505
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add an option to import k8s node labels as host tags
Motivation
Why not?
Testing Guidelines
An overview on testing
is available in our contribution guidelines.
Versioning
manifest.jsonCHANGELOG.mdAdditional Notes
Linked to DataDog/dd-agent#3445