Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove instances from flink conf.yaml #5912

Merged
merged 3 commits into from
Feb 28, 2020
Merged

Remove instances from flink conf.yaml #5912

merged 3 commits into from
Feb 28, 2020

Conversation

sarah-witt
Copy link
Contributor

What does this PR do?

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@sarah-witt sarah-witt requested review from a team as code owners February 27, 2020 20:29
sarina-dd
sarina-dd previously approved these changes Feb 27, 2020
View reviewed changes
@codecov
Copy link

codecov bot commented Feb 28, 2020

Codecov Report

Merging #5912 into master will decrease coverage by 4.57%.
The diff coverage is n/a.

Impacted Files Coverage Δ
oracle/tests/test_oracle.py
twistlock/datadog_checks/twistlock/twistlock.py
linkerd/datadog_checks/linkerd/linkerd.py
...hecks/openstack_controller/openstack_controller.py
btrfs/tests/test_btrfs.py
...nmetrics/datadog_checks/openmetrics/openmetrics.py
linkerd/datadog_checks/linkerd/metrics.py
datadog_checks_base/tests/test_warnings_util.py
statsd/datadog_checks/statsd/statsd.py
nagios/tests/common.py
... and 754 more

@sarah-witt
Copy link
Contributor Author

Depends on #5917

@ofek ofek merged commit 0686042 into master Feb 28, 2020
@ofek ofek deleted the sarah/flink-logs-only branch February 28, 2020 15:03
ofek pushed a commit that referenced this pull request Feb 28, 2020
@sarah-witt @ofek
Remove instances from flink conf.yaml (#5912)
c1ee29e 
* remove instances from conf.yaml

* Add flink to logs only

* Remove logs only
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofek ofek ofek approved these changes

@sarina-dd sarina-dd sarina-dd left review comments

Assignees
No one assigned
Labels
integration/flink
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sarah-witt @ofek @sarina-dd