Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for "osdstats" key in newer versions #5855

Merged
merged 3 commits into from
Mar 2, 2020

Conversation

ian28223
Copy link
Contributor

What does this PR do?

ceph version 14.2.7 nautilus (also in ceph/daemon:v4.0.10-stable-4.0-nautilus-centos-7) now has osd_perf_infos key under osdstats.

Previously:

{
  "osd_perf_infos": [
    {
      "id": 0,
      "perf_stats": {
        "commit_latency_ms": 0,
        "apply_latency_ms": 0,
        "commit_latency_ns": 0,
        "apply_latency_ns": 0
      }
    }
  ]
}

Now:

{
  "pg_ready": true,
  "osdstats": {
    "osd_perf_infos": [
      {
        "id": 0,
        "perf_stats": {
          "commit_latency_ms": 0,
          "apply_latency_ms": 0,
          "commit_latency_ns": 0,
          "apply_latency_ns": 0
        }
      }
    ]
  }
}

Motivation

  • 1944-ceph-int-missing-cephcommitlatencyms-applylatencyms

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@ian28223 ian28223 requested a review from a team as a code owner February 25, 2020 06:29
Just copied raw.json and added "osdstats" key

```
    "osd_perf": {
        "osdstats": {    <----
            "osd_perf_infos": [
```
@therve therve changed the title Account for "osdstats" key in newer version of Ceph Account for "osdstats" key in newer versions Mar 2, 2020
@therve therve merged commit 126e672 into master Mar 2, 2020
@therve therve deleted the ian.bucad/ceph_osdperf_osdstats branch March 2, 2020 09:23
@jforest
Copy link

jforest commented Mar 10, 2020

Is there a timeframe for when the integration that has this change in it will be released? (and consequently when the agent that includes the updated integration will be released?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants