Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new integration Apache Ignite #5767

Merged
merged 25 commits into from
Apr 22, 2020
Merged

Add new integration Apache Ignite #5767

merged 25 commits into from
Apr 22, 2020

Conversation

therve
Copy link
Contributor

@therve therve commented Feb 18, 2020

This adds a new JMX integration to monitor the Ignite database.

@therve therve requested review from a team as code owners February 18, 2020 12:40
@codecov
Copy link

codecov bot commented Mar 6, 2020 •
edited
Loading

Codecov Report

Merging #5767 into master will decrease coverage by 48.44%.
The diff coverage is 40.00%.

Impacted Files Coverage Δ
ignite/datadog_checks/ignite/__about__.py 0.00% <0.00%> (ø)
ignite/datadog_checks/ignite/__init__.py 0.00% <0.00%> (ø)
ignite/tests/test_check.py 33.33% <33.33%> (ø)
ignite/tests/conftest.py 45.00% <45.00%> (ø)
ignite/tests/common.py 100.00% <100.00%> (ø)
consul/tests/test_integration.py
pdh_check/datadog_checks/pdh_check/__about__.py
hdfs_namenode/tests/test_integration.py
druid/tests/common.py
.../datadog_checks/kube_apiserver_metrics/__init__.py
... and 862 more

ofek
ofek requested changes Mar 6, 2020
View reviewed changes
Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

ignite/tests/compose/docker-compose.yml Outdated Show resolved Hide resolved
ChristineTChen
ChristineTChen requested changes Mar 6, 2020
View reviewed changes
Copy link
Contributor

@ChristineTChen ChristineTChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!! just let a few small comments

ignite/datadog_checks/ignite/data/conf.yaml.example Outdated Show resolved Hide resolved
ignite/README.md Outdated Show resolved Hide resolved
ignite/manifest.json Outdated Show resolved Hide resolved
ignite/manifest.json Outdated Show resolved Hide resolved
l0k0ms
l0k0ms reviewed Mar 9, 2020
View reviewed changes
ignite/README.md Outdated Show resolved Hide resolved
l0k0ms
l0k0ms reviewed Mar 9, 2020
View reviewed changes
ignite/README.md Outdated Show resolved Hide resolved
l0k0ms
l0k0ms reviewed Mar 9, 2020
View reviewed changes
Copy link
Contributor

@l0k0ms l0k0ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some nits

@therve therve force-pushed the therve/ignite branch 2 times, most recently from 5b3e1d3 to 3bbb9c4 Compare March 11, 2020 08:13
hithwen
hithwen reviewed Mar 16, 2020
View reviewed changes
ignite/setup.py Outdated Show resolved Hide resolved
hithwen
hithwen reviewed Mar 16, 2020
View reviewed changes
ignite/setup.py Outdated Show resolved Hide resolved
@therve therve requested a review from a team as a code owner March 18, 2020 07:30
ofek
ofek reviewed Mar 27, 2020
View reviewed changes
ignite/tests/conftest.py Outdated Show resolved Hide resolved
@therve therve force-pushed the therve/ignite branch 2 times, most recently from 02ea6ac to 8f49b64 Compare April 6, 2020 11:27
ChristineTChen
ChristineTChen reviewed Apr 16, 2020
View reviewed changes
ignite/manifest.json Outdated Show resolved Hide resolved
ignite/tests/test_check.py Outdated
def test_e2e(dd_agent_check):
instance = {}
aggregator = dd_agent_check(instance, rate=True)
metrics = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move the two metrics list to separate file so the test is more readable?

therve and others added 24 commits April 21, 2020 11:05
@therve
Allow running JMX locally
fd626ce
@therve
Fix various metadata
ef8d431
@therve
Remove useless bits
af3334d
@therve @ChristineTChen
Apply suggestions from code review
2607c44 
Co-Authored-By: Christine Chen <[email protected]>
@therve
Add metric to check, fix format
6bb9a49
@therve
Style
1c2d4f2
@therve
Apply suggestions from code review
331b982 
Co-Authored-By: Pierre Guceski <[email protected]>
@therve
Use config spec
0a7f99e
@therve
Service check, setup.py
b332393
@therve
Sync config
a8eb44d
@therve @hithwen
Update ignite/setup.py
a94cec6 
Co-Authored-By: Julia <[email protected]>
@therve
Use a condition
2900b34
@therve
Add a deployment note
9a0730b
@therve
Sync config file
ea7b1ee
@therve
Enable log4j
c01d34d
@therve
Add log instructions
600b7d2
@therve
Update e2e
c6c35bf
@therve @ChristineTChen
Update ignite/manifest.json
4178036 
Co-Authored-By: Christine Chen <[email protected]>
@therve
Move tests metrics definition
3e715cc
@therve
Mark metrics as count in metadata
8d82b61
@therve
Add metadata assert
c51a229
@therve
Update spec
176fd70
@therve
Add logs directory
ecdce04
@therve
Style
537558b
@therve therve merged commit 1ae5907 into master Apr 22, 2020
@therve therve deleted the therve/ignite branch April 22, 2020 16:46
@ChristineTChen ChristineTChen changed the title New integration: Apache Ignite Add new integration Apache Ignite May 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l0k0ms l0k0ms l0k0ms left review comments

@hithwen hithwen hithwen left review comments

@ChristineTChen ChristineTChen ChristineTChen approved these changes

@ofek ofek ofek approved these changes

Assignees
No one assigned
Labels
dev/testing documentation integration/ignite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@therve @hithwen @l0k0ms @ofek @ChristineTChen