Improve logging and documentation #5644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
hithwen
reviewed
Feb 5, 2020
hithwen
reviewed
Feb 5, 2020
FlorianVeaux
commented
Feb 5, 2020
| import socket | ||
|
|
||
|
|
||
| def get_stream_id_for_topic(topic_name, rng=2): | ||
| def get_stream_id_for_topic(topic_name, rng=1): |
There was a problem hiding this comment.
Note for reviewer: Even though this function supports multiple rng values, we MapR default value since 6.1 si to have a single stream for all topics.
There was a problem hiding this comment.
^ that should be a in code comment
cswatt
reviewed
Feb 5, 2020
cswatt
reviewed
Feb 5, 2020
cswatt
reviewed
Feb 5, 2020
cswatt
reviewed
Feb 5, 2020
cswatt
reviewed
Feb 5, 2020
cswatt
reviewed
Feb 5, 2020
cswatt
reviewed
Feb 5, 2020
cswatt
reviewed
Feb 5, 2020
cswatt
reviewed
Feb 5, 2020
cswatt
reviewed
Feb 5, 2020
cswatt
previously approved these changes
Feb 5, 2020
ofek
requested changes
Feb 5, 2020
hithwen
approved these changes
Feb 6, 2020
ofek
approved these changes
Feb 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on recent feedback, improve the instructions on how to install the MapR integration. Also improve logging to automatically identify common painpoints and give human readable error messages.