-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kubernetes_state] - Add support for StatefulSet metrics #561
Conversation
Hey @xvello- It looks like the build failure on this occurs with the Prometheus protobuf.bin file, but I'm a little lost on how/if that can be updated to include statefulset metrics. If you have any info you can share about it, I can take a look. |
Hi @bksteiny, Thanks for your contribution! As we are currently finishing up the 5.15 release, I will have a deeper look at your PR next week, although it looks good to me on a first scan. We do have a todo card for improving the testing of the PrometheusCheck classes, by programmatically generating payloads instead of relying on captures that are hard to update when adding new metrics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great contribution, even the metadata is updated. That's a merge!
Thanks
What does this PR do?
This adds support for StatefulSet metrics, which are now exposed in kube-state-metrics (kubernetes/kube-state-metrics#151). The changes in this PR are heavily based off of #492
Motivation
As mentioned previously, these metrics are now exposed via kube-state-metrics. A kube-state-metrics release for this functionality hasn't been cut yet, but if you build the project yourself, you're able to take advantage of them.
Testing Guidelines
An overview on testing
is available in our contribution guidelines.
Before change
After change
Versioning
manifest.json
CHANGELOG.md
Additional Notes
Anything else we should know when reviewing?
I'm a little confused about the manifest version and CHANGELOG.md version changes in #492, so if what I did isn't correct, please let me know and I'll update it