Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to enable KSM experimental metrics and add some new metrics from KSM 1.9 #5447

Merged
merged 1 commit into from
Feb 19, 2020

Conversation

vboulineau
Copy link
Contributor

What does this PR do?

Customer asked for some metrics that are flagged as experimental in KSM 1.9. To protect ourselves from upstream changes that could affect our customers, we add the experimental_metrics flag to activate these metrics.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@vboulineau vboulineau requested review from a team as code owners January 13, 2020 10:40
@vboulineau vboulineau force-pushed the vboulineau/ksm_exp_metric branch 3 times, most recently from 41303a6 to 279dec4 Compare January 13, 2020 11:14
@vboulineau vboulineau force-pushed the vboulineau/ksm_exp_metric branch from 279dec4 to 0142a71 Compare January 28, 2020 15:39
Copy link
Contributor

@xornivore xornivore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vboulineau vboulineau merged commit 2cd382d into master Feb 19, 2020
@vboulineau vboulineau deleted the vboulineau/ksm_exp_metric branch February 19, 2020 12:03
@celenechang celenechang mentioned this pull request Feb 27, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants