Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document log_processing_rules for MySQL slow query logs #5237

Merged
merged 3 commits into from
Dec 18, 2019

Conversation

florimondmanca
Copy link
Contributor

What does this PR do?

Add a missing log_processing_rule entry to the MySQL config samples.

Motivation

Without this additional setting, the upcoming MySQL slow log parser (see https://github.com/DataDog/logs-backend/pull/6293) won't be able to extract any data, as the Agent would send logs on a line-by-line basis, instead of grouped as individual entries to the slow query log.

(This also means that users were seeing slow query logs line-by-line in the logs UI up to now, which is arguably a bug since slow query log lines only make sense when viewed as a group.)

Additional Notes

/

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

mysql/README.md Show resolved Hide resolved
Copy link
Member

@AlexandreYang AlexandreYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@florimondmanca florimondmanca merged commit 682affc into master Dec 18, 2019
@florimondmanca florimondmanca deleted the florimondmanca/mysql-slow-logs-docs branch December 18, 2019 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants