Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade cryptography to 2.8 #5047

Merged
merged 1 commit into from
Nov 20, 2019
Merged

Upgrade cryptography to 2.8 #5047

merged 1 commit into from
Nov 20, 2019

Conversation

remeh
Copy link
Contributor

@remeh remeh commented Nov 20, 2019

In order to build the Agent with Python 3.8, we need a compatible cryptography and the compatibility starts with cryptography 2.8.

What does this PR do?

Upgrade cryptography to 2.8.

Motivation

In order to build the Agent with Python 3.8, we need a compatible cryptography and the compatibility starts with cryptography 2.8.

Additional Notes

Issue on the cryptography repo about the Python 3.8 support pyca/cryptography#5010

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@remeh
Upgrade cryptography to 2.8
1e6768a 
In order to build the Agent with Python 3.8, we need a compatible
cryptography and the compatibility starts with cryptography 2.8.

This line change is wrong.
@remeh remeh requested review from a team as code owners November 20, 2019 15:28
@remeh remeh requested a review from therve November 20, 2019 15:28
@codecov
Copy link

codecov bot commented Nov 20, 2019 •
edited
Loading

Codecov Report

Merging #5047 into master will increase coverage by 0.59%.
The diff coverage is n/a.

Impacted Files Coverage Δ
http_check/datadog_checks/http_check/__init__.py 100% <0%> (ø) ⬆️
...penmetrics/datadog_checks/openmetrics/__about__.py 100% <0%> (ø) ⬆️
php_fpm/tests/test_e2e.py 23.8% <0%> (ø) ⬆️
couchbase/tests/test_unit.py 100% <0%> (ø) ⬆️
aerospike/tests/common.py 100% <0%> (ø) ⬆️
coredns/tests/common.py 100% <0%> (ø) ⬆️
http_check/datadog_checks/http_check/adapters.py 38.63% <0%> (ø) ⬆️
openmetrics/datadog_checks/openmetrics/__init__.py 100% <0%> (ø) ⬆️
fluentd/datadog_checks/fluentd/fluentd.py 89.36% <0%> (ø) ⬆️
http_check/tests/conftest.py 69.56% <0%> (ø) ⬆️
... and 734 more

@remeh remeh merged commit 01172a5 into master Nov 20, 2019
@remeh remeh deleted the remeh/cryptography-2_8 branch November 20, 2019 16:15
@remeh remeh mentioned this pull request Nov 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofek ofek ofek approved these changes

@therve therve Awaiting requested review from therve

Assignees
No one assigned
Labels
integration/cisco_aci integration/datadog_checks_base integration/http_check integration/mysql integration/tls
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@remeh @ofek