Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve IBM MQ docs and logging #4540

Merged
merged 5 commits into from
Sep 16, 2019
Merged

Improve IBM MQ docs and logging #4540

merged 5 commits into from
Sep 16, 2019

Conversation

AlexandreYang
Copy link
Member

@AlexandreYang AlexandreYang commented Sep 13, 2019

What does this PR do?

Improve IBM MQ docs and logging about channel status.

Motivation

I was investing why some channels where not reported.
The reason is that those channels where not used when the check was run, hence not reported.

Additional Notes

Review checklist (to be filled by reviewers)

  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • Feature or bugfix must have tests
  • Git history must be clean
  • If PR adds a configuration option, it must be added to the configuration file.

@AlexandreYang AlexandreYang changed the title Fix IBM MQ Whitelist issue [WIP] Fix IBM MQ Whitelist issue Sep 13, 2019
@AlexandreYang AlexandreYang changed the title [WIP] Fix IBM MQ Whitelist issue [WIP] Improve IBM MQ docs and logging Sep 13, 2019
@AlexandreYang AlexandreYang changed the title [WIP] Improve IBM MQ docs and logging Improve IBM MQ docs and logging Sep 13, 2019
FlorianVeaux
FlorianVeaux previously approved these changes Sep 13, 2019

```
$ ddev env start ibm_mq py27-8
$ docker exec -it ibm_mq bash
Copy link
Member

@FlorianVeaux FlorianVeaux Sep 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't that work though?

Suggested change
$ docker exec -it ibm_mq bash
$ docker exec -it ibm_mq runmqsc

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it does, thx for the suggestion :)

Simplified the commands.

@AlexandreYang AlexandreYang merged commit 0b5c0c7 into master Sep 16, 2019
@AlexandreYang AlexandreYang deleted the alex/ibm_mq_whitelist branch September 16, 2019 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants