MapR integration #4380
Merged
MapR integration #4380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
ruthnaebeck
suggested changes
Aug 23, 2019
mapr/metadata.csv
Outdated
| mapr.rpc.bytes_sent,gauge,,byte,,The number of bytes sent by the MapR Filesystem over RPC.,0,mapr, | ||
| mapr.rpc.calls_recd,gauge,,message,,The number of RPC calls received by the MapR Filesystem.,0,mapr, | ||
| mapr.topology.utilization,gauge,,percent,, The aggregate percentage of CPU utilization.,0,mapr, | ||
| mapr.topology.disks_used_capacity,gauge,,gibibyte,,The amount disk space used in gigabytes.,0,mapr, |
There was a problem hiding this comment.
gibibytes or gigabytes?
mapr/metadata.csv
Outdated
| mapr.rpc.calls_recd,gauge,,message,,The number of RPC calls received by the MapR Filesystem.,0,mapr, | ||
| mapr.topology.utilization,gauge,,percent,, The aggregate percentage of CPU utilization.,0,mapr, | ||
| mapr.topology.disks_used_capacity,gauge,,gibibyte,,The amount disk space used in gigabytes.,0,mapr, | ||
| mapr.topology.disks_total_capacity,gauge,,gibibyte,,The disk capacity in gigabytes. ,0,mapr, |
There was a problem hiding this comment.
Suggested change
| mapr.topology.disks_total_capacity,gauge,,gibibyte,,The disk capacity in gigabytes. ,0,mapr, | |
| mapr.topology.disks_total_capacity,gauge,,gibibyte,,The disk capacity in gigabytes.,0,mapr, |
gibibytes or gigabytes?
There was a problem hiding this comment.
MapR documentation says gigabytes, metadata validation only allows for gibibyte 🤷♀
FlorianVeaux
force-pushed
the
flo/mapr2
branch
from
e1fe176 to
d423695
Compare
ofek
requested changes
Sep 12, 2019
FlorianVeaux
force-pushed
the
flo/mapr2
branch
from
9202701 to
4858a1a
Compare
Co-Authored-By: ruthnaebeck <[email protected]>
FlorianVeaux
force-pushed
the
flo/mapr2
branch
2 times, most recently
from
93e170d to
8b09ff7
Compare
FlorianVeaux
force-pushed
the
flo/mapr2
branch
from
8b09ff7 to
f9b1b44
Compare
l0k0ms
reviewed
Oct 7, 2019
l0k0ms
reviewed
Oct 7, 2019
l0k0ms
reviewed
Oct 7, 2019
Co-Authored-By: Pierre Guceski <[email protected]>
Co-Authored-By: Pierre Guceski <[email protected]>
cswatt
reviewed
Oct 7, 2019
cswatt
reviewed
Oct 7, 2019
cswatt
reviewed
Oct 7, 2019
AlexandreYang
requested changes
Oct 7, 2019
Co-Authored-By: Alexandre Yang <[email protected]>
Co-Authored-By: Pierre Guceski <[email protected]>
Co-Authored-By: Alexandre Yang <[email protected]>
Co-Authored-By: Alexandre Yang <[email protected]>
Co-Authored-By: Alexandre Yang <[email protected]>
Co-Authored-By: Alexandre Yang <[email protected]>
Co-Authored-By: cswatt <[email protected]>
Co-Authored-By: cswatt <[email protected]>
Co-Authored-By: cswatt <[email protected]>
|
I added some comments about the metrics. But the type is quite difficult to check without that info in docs and without source code ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MapR integration