Remove unused version command #4249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
Codecov Report
|
hithwen
reviewed
Aug 1, 2019
| output, _, _ = get_subprocess_output(args, self.log) | ||
| except Exception as e: | ||
| raise Exception('Unable to run cmd=%s: %s' % (' '.join(args), str(e))) | ||
| ceph_args = '{} --cluster {}'.format(ceph_args, ceph_cluster) |
There was a problem hiding this comment.
We're not running the version command anymore?
There was a problem hiding this comment.
No it didn't seem to do anything.
hithwen
reviewed
Aug 1, 2019
|
|
||
| for sc in EXPECTED_SERVICE_CHECKS: | ||
| aggregator.assert_service_check(sc, status=Ceph.OK, tags=EXPECTED_SERVICE_TAGS) | ||
| aggregator.assert_service_check('ceph.overall_status', status=Ceph.OK, tags=EXPECTED_SERVICE_TAGS) |
There was a problem hiding this comment.
assert all metrics covered?
There was a problem hiding this comment.
Probably too many dynamic metrics, it's not in the integration tests either.
hithwen
approved these changes
Aug 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new e2e test, turning the local environment into a docker one. This
also allows the check to run a command made of various parts.