Fix ibm_mq e2e import issue #4140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4140 +/- ##
=========================================
- Coverage 86.29% 84.7% -1.6%
=========================================
Files 743 10 -733
Lines 39513 451 -39062
Branches 4785 55 -4730
=========================================
- Hits 34099 382 -33717
+ Misses 4143 59 -4084
+ Partials 1271 10 -1261 |
AlexandreYang
changed the title
AlexandreYang
changed the title
hithwen
reviewed
Jul 19, 2019
| CHANNEL_COUNT_CHECK = 'ibm_mq.channel.count' | ||
|
|
||
| else: | ||
| # pymqi is not be available on win/macOS when running e2e |
There was a problem hiding this comment.
pymqi is avaiblable on mac, but you need to install it: https://github.com/DataDog/integrations-core/blob/48cb9081d5b992076955afba2d13a5276c61ee63/ibm_mq/tests/README.md
There was a problem hiding this comment.
I updated the wording to be more explicit about that.
AlexandreYang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix ibm_mq e2e import issue
Motivation
e.g.
ddev env start ibm_mq py37-9wasn't working on win/osxAdditional Notes
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached